Repository navigation
Sonar: three findings from the first CI scan (S2871, S8786) - #3
Merged
Merged
Conversation
…der, linear trailing-space trim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first CI-based SonarCloud scan (#2) found three issues that automatic analysis didn't report:
routes/health.ts:oldestQueuedsorted numbers with the default.sort(), which compares them as strings. That was right only while every timestamp had the same number of digits. It's now(a, b) => a - b.db/migrate.ts: migration file names are sorted with an explicit code-unit compare, the order.sort()already used, so migrations apply in the same order.triage/knowledge-writer.tscleanDoc: trailing spaces and tabs are trimmed by a loop (trimEndSpaces) instead of/[ \t]+$/.npm run typecheckand the full vitest suite (434 tests) pass. CI runs both through the SonarCloud workflow.Still open on purpose: jssecurity:S5696 / S8475 in
public/app.js(the alert dock'ssessionStoragecache; see #1). Mark them Safe in SonarCloud, or decide to drop the instant re-show.